hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9355) Abstract symlink tests to use either FileContext or FileSystem
Date Fri, 09 Aug 2013 03:44:48 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13734364#comment-13734364
] 

Chris Nauroth commented on HADOOP-9355:
---------------------------------------

bq. won't using 'svn propset' to change the log message be problematic for the git mirrors?
I'm curious

Using svn propset to change the log message will not change the message in the commit log
of git mirrors.  You can see an example of this in my very first commit, where I forgot to
mention the jira in the commit message.  I fixed it with svn propset, so it's correct in svn
now, but not git:

{code}
chris@Chriss-MacBook-Pro:ttys000] hadoop-common-trunk                                    
                              (svn)
> svn log -r 1492297
------------------------------------------------------------------------
r1492297 | cnauroth | 2013-06-12 10:21:47 -0700 (Wed, 12 Jun 2013) | 1 line

HADOOP-9638. Parallel test changes caused invalid test path for several HDFS tests on Windows.
Contributed by Andrey Klochkov.
------------------------------------------------------------------------
{code}

{code}
[chris@Chriss-MacBook-Pro:ttys001] hadoop-common                                         
                         (git:trunk)
> git show 9bec811a502e77e0b6255b56954ad8ff4e46db27|head
commit 9bec811a502e77e0b6255b56954ad8ff4e46db27
Author: Chris Nauroth <cnauroth@apache.org>
Date:   Wed Jun 12 17:21:47 2013 +0000

    Parallel test changes caused invalid test path for several HDFS tests on Windows. Contributed
by Andrey Klochkov.
    
    git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1492297 13f79535-47bb-0310-9956-ffa450edef68
{code}

Aside from that limitation, I don't think there is any harm to the git mirrors.

The git-svn documentation mentions in the BUGS section that it ignores all svn properties
except svn:executable.

https://www.kernel.org/pub/software/scm/git/docs/git-svn.html

                
> Abstract symlink tests to use either FileContext or FileSystem
> --------------------------------------------------------------
>
>                 Key: HADOOP-9355
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9355
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>             Fix For: 2.1.0-beta
>
>         Attachments: hadoop-9355-1.patch, hadoop-9355-2.patch, hadoop-9355-3.patch, hadoop-9355-5.patch,
hadoop-9355-6.patch, hadoop-9355-7.patch, hadoop-9355-wip.patch
>
>
> We'd like to run the symlink tests using both FileContext and the upcoming FileSystem
implementation. The first step here is abstracting the test logic to run on an abstract filesystem
implementation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message