Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 618E4100D9 for ; Tue, 30 Jul 2013 04:13:55 +0000 (UTC) Received: (qmail 65249 invoked by uid 500); 30 Jul 2013 04:13:54 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 64848 invoked by uid 500); 30 Jul 2013 04:13:52 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 64465 invoked by uid 99); 30 Jul 2013 04:13:50 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jul 2013 04:13:50 +0000 Date: Tue, 30 Jul 2013 04:13:50 +0000 (UTC) From: "Aaron T. Myers (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-9786) RetryInvocationHandler#isRpcInvocation should support ProtocolTranslator MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-9786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13723375#comment-13723375 ] Aaron T. Myers commented on HADOOP-9786: ---------------------------------------- Ah, got it. Makes sense. Thanks for the explanation. Not a big deal, but in the future you might want to include a little explanation of the user-facing problem in the description of the JIRA, rather than just describing the code change. That way people like me won't have to ask. :) > RetryInvocationHandler#isRpcInvocation should support ProtocolTranslator > ------------------------------------------------------------------------- > > Key: HADOOP-9786 > URL: https://issues.apache.org/jira/browse/HADOOP-9786 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 3.0.0 > Reporter: Jing Zhao > Assignee: Jing Zhao > Attachments: HADOOP-9786.001.patch, HADOOP-9786.002.patch, HADOOP-9786.003.patch, HADOOP-9786.4.patch, HADOOP-9786.5.patch, HADOOP-9786.6.patch, HADOOP-9786.7.patch > > > Currently RetryInvocationHandler#isRpcInvocation directly uses Proxy#isProxyClass to check RetryInvocation#currentProxy. However, if currentProxy is an instance of ProtocolTranslator (e.g., ClientNamenodeProtocolTranslatorPB), the real dynamically-generated proxy object is contained within currentProxy and needs to be retrieved by calling ProtocolTranslator#getUnderlyingProxyObject. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira