Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Mon, 29 Jul 2013 15:35:50 +0000 (UTC)
From: "Tsuyoshi OZAWA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12660145.1374878427287.129075.1375112150841@arcas>
In-Reply-To: <JIRA.12660145.1374878427287@arcas>
References: <JIRA.12660145.1374878427287@arcas>
Subject: [jira] [Updated] (HADOOP-9779) create constant
 RpcConstants.CLIENT_ID_LENGTH rather than hard-coding 16 everywhere
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HADOOP-9779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsuyoshi OZAWA updated HADOOP-9779:
-----------------------------------

    Assignee: Tsuyoshi OZAWA
    
> create constant RpcConstants.CLIENT_ID_LENGTH rather than hard-coding 16 everywhere
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-9779
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9779
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Tsuyoshi OZAWA
>            Priority: Minor
>         Attachments: HADOOP-9779.1.patch
>
>
> We should create a constant RpcConstants.CLIENT_ID_LENGTH rather than hard-coding the number 16 everywhere.
> Sun Java coding style convention 10.3:
> bq. Numerical constants (literals) should not be coded directly, except for -1, 0, and 1, which can appear in a for loop as counter values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira