Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Thu, 11 Jul 2013 20:37:48 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12657025.1373443221016.35250.1373575068835@arcas>
In-Reply-To: <JIRA.12657025.1373443221016@arcas>
References: <JIRA.12657025.1373443221016@arcas>
Subject: [jira] [Commented] (HADOOP-9716) Move the Rpc request call ID
 generation to client side InvocationHandler
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-9716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706200#comment-13706200 ] 

Hadoop QA commented on HADOOP-9716:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12591899/c9716_20130712b.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.ipc.TestRPC
                  org.apache.hadoop.ipc.TestIPC
                  org.apache.hadoop.io.retry.TestRetryProxy
                  org.apache.hadoop.io.retry.TestFailoverProxy
                  org.apache.hadoop.ipc.TestIPCServerResponder

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2772//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2772//console

This message is automatically generated.
                
> Move the Rpc request call ID generation to client side InvocationHandler
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-9716
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9716
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Suresh Srinivas
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: c9716_20130712b.patch, c9716_20130712.patch
>
>
> Currently when RetryInvocationHandler is used to retry an RPC request, a new RPC request call ID is generated. This jira proposes moving call ID generation to InvocationHandler so that retried RPC requests retain the same call ID. This is needed for RetryCache functionality proposed in HDFS-4942.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira