Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4FCC210ED6 for ; Wed, 10 Jul 2013 13:07:53 +0000 (UTC) Received: (qmail 40420 invoked by uid 500); 10 Jul 2013 13:07:52 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 40313 invoked by uid 500); 10 Jul 2013 13:07:52 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 40175 invoked by uid 99); 10 Jul 2013 13:07:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jul 2013 13:07:52 +0000 Date: Wed, 10 Jul 2013 13:07:52 +0000 (UTC) From: "Hudson (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-9691) RPC clients can generate call ID using AtomicInteger instead of synchronizing on the Client instance. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-9691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704527#comment-13704527 ] Hudson commented on HADOOP-9691: -------------------------------- Integrated in Hadoop-Hdfs-trunk #1456 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1456/]) HADOOP-9691. RPC clients can generate call ID using AtomicInteger instead of synchronizing on the Client instance. Contributed by Chris Nauroth. (Revision 1501615) Result = FAILURE cnauroth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501615 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcConstants.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java > RPC clients can generate call ID using AtomicInteger instead of synchronizing on the Client instance. > ----------------------------------------------------------------------------------------------------- > > Key: HADOOP-9691 > URL: https://issues.apache.org/jira/browse/HADOOP-9691 > Project: Hadoop Common > Issue Type: Improvement > Components: ipc > Affects Versions: 3.0.0, 2.1.0-beta > Reporter: Chris Nauroth > Assignee: Chris Nauroth > Priority: Minor > Fix For: 3.0.0 > > Attachments: HADOOP-9691.1.patch, HADOOP-9691.2.patch, HADOOP-9691.3.patch > > > As noted in discussion on HADOOP-9688, we can optimize generation of call ID in the RPC client code. Currently, it synchronizes on the {{Client}} instance to coordinate access to a shared {{int}}. We can switch this to {{AtomicInteger}} to avoid lock contention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira