hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9786) RetryInvocationHandler#isRpcInvocation should support ProtocolTranslator
Date Tue, 30 Jul 2013 04:49:49 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13723397#comment-13723397
] 

Hadoop QA commented on HADOOP-9786:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12594859/HADOOP-9786.7.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2879//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2879//console

This message is automatically generated.
                
> RetryInvocationHandler#isRpcInvocation should support ProtocolTranslator 
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-9786
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9786
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HADOOP-9786.001.patch, HADOOP-9786.002.patch, HADOOP-9786.003.patch,
HADOOP-9786.4.patch, HADOOP-9786.5.patch, HADOOP-9786.6.patch, HADOOP-9786.7.patch
>
>
> Currently the RetryInvocationHandler uses the same RPC ids (i.e., clientId + callId)
only when the invocation is a RPC invocation. To check whether an invocation is RPC, RetryInvocationHandler#isRpcInvocation
directly apply Proxy#isProxyClass on RetryInvocation#currentProxy. However, if currentProxy
is an instance of ProtocolTranslator (e.g., ClientNamenodeProtocolTranslatorPB), the real
dynamically-generated proxy object is contained within currentProxy and needs to be retrieved
by calling ProtocolTranslator#getUnderlyingProxyObject. Failing to recognize a RPC invocation
can cause a retry request to have different "clientId + callId" with its initial call, and
fail to hit the corresponding retry cache entry in the NameNode side.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message