hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9783) Fix OS detection for RawLocalFileSystem#getFileLinkStatus fallback path
Date Mon, 29 Jul 2013 17:43:49 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13722710#comment-13722710
] 

Arpit Agarwal commented on HADOOP-9783:
---------------------------------------

Hi Andrew, thanks for the prompt fix!

I verified it fixes the regression on OS X. I like Colin's suggestion of prepending IS_ to
the OS flags in Shell. It will be a larger change since Shell.WINDOWS is used quite extensively
in the codebase.

+1 otherwise.
                
> Fix OS detection for RawLocalFileSystem#getFileLinkStatus fallback path
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-9783
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9783
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 2.3.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hadoop-9783-1.patch
>
>
> HADOOP-9652 calls out to {{stat(1)}} on supported platforms to get additional file metadata
and handle symlinks. The old, incorrect fallback path was left in for unsupported platforms.
However, the fallback is currently only in place for Windows; let's make it for any unsupported
platform (e.g. Mac).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message