hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Larry McCay (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9726) org.apache.hadoop.security.SecurityUtil has its own static Configuration which cannot be overridden
Date Fri, 12 Jul 2013 19:05:54 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707260#comment-13707260
] 

Larry McCay commented on HADOOP-9726:
-------------------------------------

My two cents:

1. I don't understand why there is configuration for a utils class
2. a static initialization block and a static setter for this both stand out as an anti-pattern
to be avoided - this will introduce problems in the long run where multiple tenants or the
like require different settings - perhaps even in tests we need different settings

I don't believe the answer is to continue the anti-pattern but rather to refactor the utils
class to accept the settings as part of the interaction.

Hitesh - what is the scenario that you need to override the settings for?

                
> org.apache.hadoop.security.SecurityUtil has its own static Configuration which cannot
be overridden
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9726
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9726
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>
> There is a static block which loads a new Configuration object and uses it to initialize
the SSLFactory and HostResolver.
> Should this class have a similar static setConfiguration() function similar to UGI? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message