hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9691) RPC clients can generate call ID using AtomicInteger instead of synchronizing on the Client instance.
Date Wed, 10 Jul 2013 13:07:52 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704527#comment-13704527
] 

Hudson commented on HADOOP-9691:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #1456 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1456/])
    HADOOP-9691. RPC clients can generate call ID using AtomicInteger instead of synchronizing
on the Client instance. Contributed by Chris Nauroth. (Revision 1501615)

     Result = FAILURE
cnauroth : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501615
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcConstants.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java

                
> RPC clients can generate call ID using AtomicInteger instead of synchronizing on the
Client instance.
> -----------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9691
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9691
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 3.0.0, 2.1.0-beta
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-9691.1.patch, HADOOP-9691.2.patch, HADOOP-9691.3.patch
>
>
> As noted in discussion on HADOOP-9688, we can optimize generation of call ID in the RPC
client code.  Currently, it synchronizes on the {{Client}} instance to coordinate access to
a shared {{int}}.  We can switch this to {{AtomicInteger}} to avoid lock contention.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message