hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9668) Configuration#iterator method should interpret variables in a property as well as Configuration#get method
Date Wed, 17 Jul 2013 05:30:51 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13710728#comment-13710728
] 

Hadoop QA commented on HADOOP-9668:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12592704/HADOOP-9668.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.conf.TestReconfiguration

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2794//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2794//console

This message is automatically generated.
                
> Configuration#iterator method should interpret variables in a property as well as Configuration#get
method
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9668
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9668
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 2.1.0-beta, 1.2.1
>            Reporter: Kousuke Saruta
>            Priority: Minor
>              Labels: newbie
>         Attachments: HADOOP-9668-branch-2.1.0-beta.patch, HADOOP-9668.patch
>
>
> o.a.h.conf.Configuration#get method interpret variables in a property in *-site.xml but
Configuration#iterator method doesn't.
> For example, when a property "user.name" is set to "hadoop" and another property "hadoop.tmp.dir"
is set to "/tmp/${user.name}", Configuration#get interpret "hadoop.tmp.dir" as "/tmp/hadoop"
but Configuration#iterator doesn't interpret.
> I think Configuration#iterator should interpret variables or if there are some reasons,
it should be documented that Configuration#iterator doesn't interpret variables.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message