hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9652) RawLocalFs#getFileLinkStatus does not fill in the link owner and mode
Date Fri, 12 Jul 2013 22:31:49 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707472#comment-13707472
] 

Andrew Wang commented on HADOOP-9652:
-------------------------------------

Thanks Colin.

bq. Symlinks created by the test user should be owned by him.

True, I added the username check back in. The other tests are unfortunately harder; for instance,
symlink permissions are inconsistent across operating systems, and it's unclear to me which
of the user's groups is set.

Fixed your other comment too.

I also realized the earlier patch removed Windows support, so I brought the old functions
back as a fallback. I think it'd be better to eventually add Windows support to the Stat class
so we can remove the old code. Though it should be fine, I haven't tested this on windows
either, so maybe [~cnauroth] or [~ivanmi] could verify since we'd like to get this into 2.1.
                
> RawLocalFs#getFileLinkStatus does not fill in the link owner and mode
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-9652
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9652
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Andrew Wang
>         Attachments: hadoop-9452-1.patch, hadoop-9652-2.patch
>
>
> {{RawLocalFs#getFileLinkStatus}} does not actually get the owner and mode of the symlink,
but instead uses the owner and mode of the symlink target.  If the target can't be found,
it fills in bogus values (the empty string and FsPermission.getDefault) for these.
> Symlinks have an owner distinct from the owner of the target they point to, and getFileLinkStatus
ought to expose this.
> In some operating systems, symlinks can have a permission other than 0777.  We ought
to expose this in RawLocalFilesystem and other places, although we don't necessarily have
to support this behavior in HDFS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message