hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9652) RawLocalFs#getFileLinkStatus does not fill in the link owner and mode
Date Wed, 24 Jul 2013 23:47:49 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719033#comment-13719033
] 

Andrew Wang commented on HADOOP-9652:
-------------------------------------

Thanks for the review Colin, new patch attached.

bq. Newly created files get set to the user's primary group on UNIX.

TY, added that check back in.

bq. impossible to view relative symlink paths once they are created

I think FileSystem#getLinkTarget serves this purpose; targets are returned as set.

bq. Shouldn't this be OS_TYPE_LINUX?

Truth, changed it to LINUX. It's not actually a positive Linux detection though, since it's
the default OSType.

bq. We should also really also file a follow-up bug to remove this and move to a more portable
solution when we get the green light to drop JDK6 support.

Definitely agree on this, there are lots of places we shell out to workaround Java 6. I'll
file a JIRA.
                
> RawLocalFs#getFileLinkStatus does not fill in the link owner and mode
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-9652
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9652
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Andrew Wang
>         Attachments: hadoop-9452-1.patch, hadoop-9652-2.patch, hadoop-9652-3.patch
>
>
> {{RawLocalFs#getFileLinkStatus}} does not actually get the owner and mode of the symlink,
but instead uses the owner and mode of the symlink target.  If the target can't be found,
it fills in bogus values (the empty string and FsPermission.getDefault) for these.
> Symlinks have an owner distinct from the owner of the target they point to, and getFileLinkStatus
ought to expose this.
> In some operating systems, symlinks can have a permission other than 0777.  We ought
to expose this in RawLocalFilesystem and other places, although we don't necessarily have
to support this behavior in HDFS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message