Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5D9FB10D7F for ; Fri, 14 Jun 2013 22:03:23 +0000 (UTC) Received: (qmail 10371 invoked by uid 500); 14 Jun 2013 22:03:23 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 10339 invoked by uid 500); 14 Jun 2013 22:03:23 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 10330 invoked by uid 99); 14 Jun 2013 22:03:23 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Jun 2013 22:03:22 +0000 Date: Fri, 14 Jun 2013 22:03:22 +0000 (UTC) From: "Suresh Srinivas (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-8545) Filesystem Implementation for OpenStack Swift MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-8545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suresh Srinivas updated HADOOP-8545: ------------------------------------ Attachment: HADOOP-8545.suresh.patch Here is an updated patch. I have made members finals where possible and removed setters in the classes. I also have added @Override where needed. I also changes deprecated method call FileStatus#isDir() to FileStatus#isDirectory(). Some places where IOException is unnecessarily declared as thrown, I have removed them. I thought it is more efficient to just update the patch for these changes instead of listing them as comments. Other comments: # General #* Instead of using _ in variable names, use camel case #* There are still TODOs and commented code in the patch that needs to be cleaned up # Some of the Swift*Exception exceptions are missing javadoc # SwiftRestClient #filesystemURI, getObjectLocationURI(), catalogMatch are ununsed. # SwiftObjectFileStatus needs javadoc # SwiftNativeInputStream#contentLength is unused and can be removed # SwiftNativeFileSystem#mkdir is ununsed and can be removed # Path#hasUriSchem is unused and can be removed # Duration class needs javadoc I will do a second review during this weekend/Monday next week. > Filesystem Implementation for OpenStack Swift > --------------------------------------------- > > Key: HADOOP-8545 > URL: https://issues.apache.org/jira/browse/HADOOP-8545 > Project: Hadoop Common > Issue Type: New Feature > Components: fs > Affects Versions: 1.2.0, 2.0.3-alpha > Reporter: Tim Miller > Assignee: Dmitry Mezhensky > Labels: hadoop, patch > Attachments: HADOOP-8545-026.patch, HADOOP-8545-027.patch, HADOOP-8545-028.patch, HADOOP-8545-029.patch, HADOOP-8545-10.patch, HADOOP-8545-11.patch, HADOOP-8545-12.patch, HADOOP-8545-13.patch, HADOOP-8545-14.patch, HADOOP-8545-15.patch, HADOOP-8545-16.patch, HADOOP-8545-17.patch, HADOOP-8545-18.patch, HADOOP-8545-19.patch, HADOOP-8545-1.patch, HADOOP-8545-20.patch, HADOOP-8545-21.patch, HADOOP-8545-22.patch, HADOOP-8545-23.patch, HADOOP-8545-24.patch, HADOOP-8545-25.patch, HADOOP-8545-2.patch, HADOOP-8545-3.patch, HADOOP-8545-4.patch, HADOOP-8545-5.patch, HADOOP-8545-6.patch, HADOOP-8545-7.patch, HADOOP-8545-8.patch, HADOOP-8545-9.patch, HADOOP-8545-javaclouds-2.patch, HADOOP-8545.patch, HADOOP-8545.patch, HADOOP-8545.suresh.patch > > > ,Add a filesystem implementation for OpenStack Swift object store, similar to the one which exists today for S3. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira