Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5F453CBF1 for ; Mon, 3 Jun 2013 07:38:23 +0000 (UTC) Received: (qmail 20052 invoked by uid 500); 3 Jun 2013 07:38:23 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 19971 invoked by uid 500); 3 Jun 2013 07:38:22 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 19938 invoked by uid 99); 3 Jun 2013 07:38:21 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Jun 2013 07:38:21 +0000 Date: Mon, 3 Jun 2013 07:38:21 +0000 (UTC) From: "Hudson (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-8469) Make NetworkTopology class pluggable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13672873#comment-13672873 ] Hudson commented on HADOOP-8469: -------------------------------- Integrated in Hadoop-trunk-Commit #3836 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3836/]) Move HADOOP-8469 and HADOOP-8470 to 2.1.0-beta in CHANGES.txt. (Revision 1488873) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1488873 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt > Make NetworkTopology class pluggable > ------------------------------------ > > Key: HADOOP-8469 > URL: https://issues.apache.org/jira/browse/HADOOP-8469 > Project: Hadoop Common > Issue Type: Sub-task > Affects Versions: 1.0.0, 2.0.0-alpha > Reporter: Junping Du > Assignee: Junping Du > Fix For: 1.2.0, 2.1.0-beta > > Attachments: HADOOP-8469-branch-2-02.patch, HADOOP-8469-branch-2.patch, HADOOP-8469-NetworkTopology-pluggable.patch, HADOOP-8469-NetworkTopology-pluggable-v2.patch, HADOOP-8469-NetworkTopology-pluggable-v3.patch, HADOOP-8469-NetworkTopology-pluggable-v4.patch, HADOOP-8469-NetworkTopology-pluggable-v5.patch > > > The class NetworkTopology is where the three-layer hierarchical topology is modeled in the current code base and is instantiated directly by the DatanodeManager and Balancer. > To support alternative topologies, changes were make the topology class pluggable, that is to support using a user specified topology class specified in the Hadoop configuration file core-defaul.xml. The user specified topology class is instantiated using reflection in the same manner as other customizable classes in Hadoop. If no use specified topology class is found, the fallback is to use the NetworkTopology to preserve current behavior. To make it possible to reuse code in NetworkTopology several minor changes were made to make the class more extensible. The NetworkTopology class is currently annotated with @InterfaceAudience.LimitedPrivate({"HDFS", "MapReduce"}) and @InterfaceStability.Unstable. > The proposed changes in NetworkTopology listed below > 1. Some fields were changes from private to protected > 2. Added some protected methods so that sub classes could override behavior > 3. Added a new method,isNodeGroupAware,to NetworkTopology > 4. The inner class InnerNode was made a package protected class to it would be easier to subclass -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira