hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhijie Shen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-9665) BlockDecompressorStream#decompress will throw EOFException instead of return -1 when EOF
Date Fri, 28 Jun 2013 21:35:22 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-9665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Zhijie Shen updated HADOOP-9665:
--------------------------------

    Attachment: HADOOP-9665-branch-1.1.patch

Backporting to branch-1
                
> BlockDecompressorStream#decompress will throw EOFException instead of return -1 when
EOF
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9665
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9665
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.1.2, 2.1.0-beta, 2.2.0
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>            Priority: Critical
>         Attachments: HADOOP-9665.1.patch, HADOOP-9665.2.patch, HADOOP-9665-branch-1.1.patch
>
>
> BlockDecompressorStream#decompress ultimately calls rawReadInt, which will throw EOFException
instead of return -1 when encountering end of a stream. Then, decompress will be called by
read. However, InputStream#read is supposed to return -1 instead of throwing EOFException
to indicate the end of a stream. This explains why in LineReader,
> {code}
>       if (bufferPosn >= bufferLength) {
>         startPosn = bufferPosn = 0;
>         if (prevCharCR)
>           ++bytesConsumed; //account for CR from previous read
>         bufferLength = in.read(buffer);
>         if (bufferLength <= 0)
>           break; // EOF
>       }
> {code}
> -1 is checked instead of catching EOFException.
> Now the problem will occur with SnappyCodec. If an input file is compressed with SnappyCodec,
it needs to be decompressed through BlockDecompressorStream when it is read. Then, if it empty,
EOFException will been thrown from rawReadInt and break LineReader.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message