hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9630) Remove IpcSerializationType
Date Tue, 11 Jun 2013 01:37:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13680129#comment-13680129
] 

Hadoop QA commented on HADOOP-9630:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12587176/HADOOP-9630.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2627//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2627//console

This message is automatically generated.
                
> Remove IpcSerializationType
> ---------------------------
>
>                 Key: HADOOP-9630
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9630
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Luke Lu
>            Assignee: Junping Du
>              Labels: rpc
>         Attachments: HADOOP-9630.patch
>
>
> IpcSerializationType is assumed to be protobuf for the forseeable future. Not to be confused
with RpcKind which still supports different RpcEngines. Let's remove the dead code, which
can be confusing to maintain.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message