hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Eagles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9614) smart-test-patch.sh hangs for new version of patch (2.7.1)
Date Mon, 03 Jun 2013 19:22:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13673457#comment-13673457
] 

Jonathan Eagles commented on HADOOP-9614:
-----------------------------------------

+1. Looks good to me based on change listed in patch's git repository
remote.origin.url=git://git.savannah.gnu.org/patch.git
commit 3ccb16e10b7b4312e9b6096760ddc4c2d90194f2
Date:   Tue Apr 17 22:37:17 2012 +0200

    Improve messages when in --dry-run mode
    
    * src/patch.c (main): Say that we are checking a file and not that we are
    patching it in --dry-run mode.  Don't say "saving rejects to file" when we
    don't create reject files.
    * tests/reject-format: Add rejects with --dry-run test case.
    * tests/bad-filenames, tests/fifo, tests/mixed-patch-types: Update.


                
> smart-test-patch.sh hangs for new version of patch (2.7.1)
> ----------------------------------------------------------
>
>                 Key: HADOOP-9614
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9614
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 0.23.7, 2.0.4-alpha
>            Reporter: Ravi Prakash
>            Assignee: Ravi Prakash
>         Attachments: HADOOP-9614.patch, HADOOP-9614.patch
>
>
> patch -p0 -E --dry-run prints "checking file " for the new version of patch(2.7.1) rather
than "patching file" as it did for older versions. This causes TMP2 to become empty, which
causes the script to hang on this command forever:
>     PREFIX_DIRS_AND_FILES=$(cut -d '/' -f 1 | sort | uniq)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message