hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Mitic (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9609) Remove sh dependency of bin-package target
Date Mon, 03 Jun 2013 22:24:23 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13673687#comment-13673687

Ivan Mitic commented on HADOOP-9609:

Thanks Chuan for reporting the problem and for the patch!

Your patch seem to introduce a different behavior on Linux platforms. I don’t think we want
to do this (see HADOOP-8037 for some history on what it’s done in packageBinNativeHadoop.sh).
I see two possible alternatives we can move forward with:
1.	Use packageNativeHadoop.py for both package and bin-package target when on Windows, but
still use packageBinNativeHadoop.sh when on Linux. This would be a quick and simple fix for
this Jira.
2.	Create packageBinNativeHadoop.py that would be a Windows equivalent of packageBinNativeHadoop.sh.
This would however require a bit more work, as we’d want to satisfy the idea behind the
bin-package target, which is to produce a platform specific target (for example, on Windows
this would be hadoop-x.y.z-amd64-bin.winpkg.zip). 

I am personally fine with both approaches. Let me know what you think. 
> Remove sh dependency of bin-package target
> ------------------------------------------
>                 Key: HADOOP-9609
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9609
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1-win
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>            Priority: Minor
>         Attachments: HADOOP-9609-branch-1-win.patch
> In Ant package target, we no longer use packageBinNativeHadoop.sh to place native library
binaries. However, the same script is still present in the bin-package target. We should remove
bin-package target's dependency on sh to keep it consistent with package target.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message