hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9582) Non-existent file to "hadoop fs -conf" doesn't throw error
Date Thu, 13 Jun 2013 22:35:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682845#comment-13682845
] 

Jason Lowe commented on HADOOP-9582:
------------------------------------

Seems reasonable to at least make a small improvement to FsShell to catch bad -conf parameters,
and that should be lower risk than having GenericOptionsParser start blindly setting all Configurations
passed to it as non-quiet.

Some comments on the latest patch:

* TestGenericOptionsParser change now seems moot, since we didn't modify GenericOptionsParser
and it doesn't test the FsShell change.
* Nit: In TestFsShell rather than wielding AssertionFailedError directly we can simply use
assertTrue(th instanceof RuntimeException)
                
> Non-existent file to "hadoop fs -conf" doesn't throw error
> ----------------------------------------------------------
>
>                 Key: HADOOP-9582
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9582
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 3.0.0, 0.23.7, 2.0.4-alpha
>            Reporter: Ashwin Shankar
>         Attachments: HADOOP-9582.txt, HADOOP-9582.txt, HADOOP-9582.txt
>
>
> When we run :
> hadoop fs -conf BAD_FILE -ls /
> we expect hadoop to throw an error,but it doesn't.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message