hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Mitic (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9527) TestLocalFSFileContextSymlink is broken on Windows
Date Fri, 07 Jun 2013 03:51:22 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677790#comment-13677790
] 

Ivan Mitic commented on HADOOP-9527:
------------------------------------

Latest patch looks much better Arpit. Thanks for addressing the comments.

I still want to reiterate on above comment #2 and have one additional question:
 - We have already seen that miss use of Paths or Strings can cause problems because of different
path semantics (for example, API consumers passing paths with forward slashes on Windows).
File object makes it explicit that a local file system path is required. Let's please add
a single public API {{String FileUtil.readLink(File)}} and work based off of that.
 - FileUtil.java: I am not able to understand this part
{code}
        // Relative links on Windows must be resolvable at the time of
        // creation. To ensure this we run the shell command in the directory
        // of the link.
{code}
Why would a parent directory of a link be the appropriate working directory?
                
> TestLocalFSFileContextSymlink is broken on Windows
> --------------------------------------------------
>
>                 Key: HADOOP-9527
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9527
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.3.0
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>         Attachments: HADOOP-9527.001.patch, HADOOP-9527.002.patch, HADOOP-9527.003.patch,
HADOOP-9527.004.patch, HADOOP-9527.005.patch, HADOOP-9527.006.patch, HADOOP-9527.007.patch,
HADOOP-9527.008.patch, RenameLink.java
>
>
> Multiple test cases are broken. I didn't look at each failure in detail.
> The main cause of the failures appears to be that RawLocalFS.readLink() does not work
on Windows. We need "winutils readlink" to fix the test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message