Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D2F4C1175D for ; Fri, 10 May 2013 21:41:16 +0000 (UTC) Received: (qmail 41168 invoked by uid 500); 10 May 2013 21:41:16 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 41063 invoked by uid 500); 10 May 2013 21:41:16 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 41053 invoked by uid 99); 10 May 2013 21:41:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 May 2013 21:41:16 +0000 Date: Fri, 10 May 2013 21:41:16 +0000 (UTC) From: "Aaron T. Myers (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-9485) No default value in the code for hadoop.rpc.socket.factory.class.default MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-9485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aaron T. Myers updated HADOOP-9485: ----------------------------------- Summary: No default value in the code for hadoop.rpc.socket.factory.class.default (was: inconsistent defaults for hadoop.rpc.socket.factory.class.default) +1, the latest patch looks good to me. I'm going to commit this momentarily. > No default value in the code for hadoop.rpc.socket.factory.class.default > ------------------------------------------------------------------------ > > Key: HADOOP-9485 > URL: https://issues.apache.org/jira/browse/HADOOP-9485 > Project: Hadoop Common > Issue Type: Bug > Components: net > Affects Versions: 2.0.5-beta > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Priority: Minor > Attachments: HADOOP-9485.001.patch, HADOOP-9485.002.patch, HADOOP-9485.003.patch, HADOOP-9485.004.patch, HADOOP-9485.005.patch, HADOOP-9485.006.patch > > > In {{core-default.xml}}, {{hadoop.rpc.socket.factory.class.default}} defaults to {{org.apache.hadoop.net.StandardSocketFactory}}. However, in {{CommonConfigurationKeysPublic.java}}, there is no default for this key. This is inconsistent (defaults in the code versus defaults in the XML files should match.) It also leads to problems with {{RemoteBlockReader2}}, since the default {{SocketFactory}} creates a {{Socket}} without an associated channel. {{RemoteBlockReader2}} cannot use such a {{Socket}}. > This bug only really becomes apparent when you create a {{Configuration}} using the {{Configuration(loadDefaults=true)}} constructor. Thanks to AB Srinivasan for his help in discovering this bug. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira