Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B0A3AF5C1 for ; Thu, 2 May 2013 21:30:19 +0000 (UTC) Received: (qmail 78615 invoked by uid 500); 2 May 2013 21:30:19 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 78568 invoked by uid 500); 2 May 2013 21:30:19 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 78519 invoked by uid 99); 2 May 2013 21:30:19 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 May 2013 21:30:18 +0000 Date: Thu, 2 May 2013 21:30:18 +0000 (UTC) From: "Chris Nauroth (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-9483) winutils support for readlink command MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647917#comment-13647917 ] Chris Nauroth commented on HADOOP-9483: --------------------------------------- +1 for the patch. Looks good! One minor thing: my latest patch on HADOOP-9043 puts the {{assumeTrue}} call into a {{@Before}} method so that the individual tests don't need to check it. Whichever of these patches gets committed first, the other one can rebase easily. > winutils support for readlink command > ------------------------------------- > > Key: HADOOP-9483 > URL: https://issues.apache.org/jira/browse/HADOOP-9483 > Project: Hadoop Common > Issue Type: Improvement > Components: util > Affects Versions: 3.0.0 > Reporter: Chris Nauroth > Assignee: Arpit Agarwal > Attachments: HADOOP-9483.003.patch, HADOOP-9483.004.patch, HADOOP-9483.005.patch, HADOOP-9483.patch, HADOOP-9483.patch > > > The current codebase relies on the Unix readlink command to determine the target of a symlink on the local file system. winutils currently does not support this functionality on Windows. Adding the command to winutils will prevent the need to use GnuWin32 or Cygwin for readlink support. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira