Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9525D981D for ; Fri, 24 May 2013 22:58:21 +0000 (UTC) Received: (qmail 27463 invoked by uid 500); 24 May 2013 22:58:21 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 27402 invoked by uid 500); 24 May 2013 22:58:21 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 27393 invoked by uid 99); 24 May 2013 22:58:21 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 May 2013 22:58:21 +0000 Date: Fri, 24 May 2013 22:58:21 +0000 (UTC) From: "Suresh Srinivas (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-9443) Port winutils static code analysis change to trunk MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-9443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suresh Srinivas updated HADOOP-9443: ------------------------------------ Fix Version/s: (was: 3.0.0) 2.0.5-beta I merged the patch to branch-2. > Port winutils static code analysis change to trunk > -------------------------------------------------- > > Key: HADOOP-9443 > URL: https://issues.apache.org/jira/browse/HADOOP-9443 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 3.0.0 > Reporter: Chuan Liu > Assignee: Chuan Liu > Fix For: 2.0.5-beta > > Attachments: HADOOP-9443-trunk.patch > > > We hit a problem in winutils when running tests on Windows. The static code analysis change will fix the problem. More specifically, the old code always assumes the security descriptor get from GetSecurityDescriptorControl() is relative, and will make an absolute security descriptor out of it. The new absolute security descriptor will then pass to SetSecurityDescriptorDacl() to set permissions on the file. If the security descriptor is absolute, the new absolute security descriptor will be NULL, and we will run into the problem. This is what happened exactly in our case. The fix from static code analysis will solve the problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira