hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9583) test-patch gives +1 despite build failure when running tests
Date Tue, 21 May 2013 14:47:17 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663030#comment-13663030
] 

Jason Lowe commented on HADOOP-9583:
------------------------------------

Sure, that sounds reasonable.  If that's not reliable I'm even OK with test-patch simply commenting
along the lines of "-1 tests.  The test build failed" and leave it up to someone to dig through
the console output to figure out what happened.  The worst thing to do is ignore the build
failure which is what it does today.  Maybe a combination of the two approaches?  Look for
tests that timeout and call them out individually if found, but even if none are found don't
allow a build failure to result in a +1 for the patch.
                
> test-patch gives +1 despite build failure when running tests
> ------------------------------------------------------------
>
>                 Key: HADOOP-9583
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9583
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Jason Lowe
>            Priority: Critical
>
> I've seen a couple of checkins recently where tests have timed out resulting in a Maven
build failure yet test-patch reports an overall +1 on the patch.  This is encouraging commits
of patches that subsequently break builds.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message