[ https://issues.apache.org/jira/browse/HADOOP-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13666867#comment-13666867
]
Vinod Kumar Vavilapalli commented on HADOOP-9574:
-------------------------------------------------
Want to move forward with this for the sake of YARN-638.
Mostly looks good to me. Can you add tests to make sure these new APIs are correctly called?
You can modify TestDelegationTokenSecretManager.
Also, a couple of simple tests for DelegationKey changes will be great.
> Add new methods in AbstractDelegationTokenSecretManager for restoring RMDelegationTokens
on RMRestart
> -----------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9574
> URL: https://issues.apache.org/jira/browse/HADOOP-9574
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Jian He
> Assignee: Jian He
> Attachments: HADOOP-9574.1.patch
>
>
> we're considering to add the following methods in AbstractDelegationTokenSecretManager
for restoring RMDelegationTokens, these methods can also possibly be reused by hdfsDelegationTokenSecretManager,
see YARN-638
> protected void storeNewMasterKey(DelegationKey key) throws IOException {
> return;
> }
> protected void removeStoredMasterKey(DelegationKey key) {
> return;
> }
> protected void storeNewToken(TokenIdent ident, long renewDate) {
> return;
> }
> protected void removeStoredToken(TokenIdent ident) throws IOException {
> }
> protected void updateStoredToken(TokenIdent ident, long renewDate) {
> return;
> }
> Also move addPersistedDelegationToken in hdfs.DelegationTokenSecretManager, to AbstractDelegationTokenSecretManager
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
|