hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-9483) winutils support for readlink command
Date Thu, 02 May 2013 04:10:16 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Arpit Agarwal updated HADOOP-9483:

    Attachment: HADOOP-9483.004.patch

Addressed your comments.

 10. I see what you're trying to do with the for loop. However, this won't work when you get
ERROR_MORE_DATA back, right? I say, let's just allocate a 1024 size array on stack, and if
the this is not enough, have the function fail. If in the future this turns out to be a problem,
we can fix it (what is very unlikely to happen). Make sense?

It works when the return code is ERROR_MORE_DATA. It can be confirmed with a buffer larger
than sizeof(REPARSE_DATA_BUFFER) but not large enough for the path strings. Since we are handling
long paths it makes all the more sense to handle this case. :)
> winutils support for readlink command
> -------------------------------------
>                 Key: HADOOP-9483
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9483
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 3.0.0
>            Reporter: Chris Nauroth
>            Assignee: Arpit Agarwal
>         Attachments: HADOOP-9483.003.patch, HADOOP-9483.004.patch, HADOOP-9483.patch,
> The current codebase relies on the Unix readlink command to determine the target of a
symlink on the local file system.  winutils currently does not support this functionality
on Windows.  Adding the command to winutils will prevent the need to use GnuWin32 or Cygwin
for readlink support.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message