hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luke Lu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9421) Convert SASL to use ProtoBuf and add lengths for non-blocking processing
Date Fri, 17 May 2013 16:37:17 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13660839#comment-13660839

Luke Lu commented on HADOOP-9421:

bq. I'm curious how RPC v9 testing is blocked by the SASL changes?

The goal of RPC v9 is to make sure every aspect of RPC is covered by a protobuf consistently,
which enables compatible evolution moving forward. We hope that RPC v10 will not be necessary.
The current patch needs cleanup but the scope addresses this issue adequately AFAICT.

bq. The demo patch appears to propagate the current limited design which will be very difficult
to support in combination with the new design.

I don't see why it's difficult to support arbitrary new designs with the protobuf change,
which is fairly generic in terms of wireformat (sasl (request, response) tuples that could
contain anything fields). The new code can simply branch out on the sasl rpc version introduced
by the patch.

bq. I'm also not sure why the SASL protobuf should contain error messages instead of leverage
the existing error/fatal RPC response.

Because sasl rpc is (and should not be) not part of the rpc engine. It's essentially a simple
prelude to the real rpc exchange. Since we've decided that sasl exchange will always end with
a status from server, it's natural to report error there. This keep the sasl rpc logic simple
(only deals with sasl (request, response)? protos) and separate from the main rpc logic, which
seems to be a nice separation of concerns here.
> Convert SASL to use ProtoBuf and add lengths for non-blocking processing
> ------------------------------------------------------------------------
>                 Key: HADOOP-9421
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9421
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 2.0.3-alpha
>            Reporter: Sanjay Radia
>            Assignee: Junping Du
>         Attachments: HADOOP-9421.patch, HADOOP-9421-v2-demo.patch

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message