Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Tue, 30 Apr 2013 01:58:15 +0000 (UTC)
From: "Aaron T. Myers (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12633425.1361465999298.245819.1367287095897@arcas>
In-Reply-To: <JIRA.12633425.1361465999298@arcas>
References: <JIRA.12633425.1361465999298@arcas>
Subject: [jira] [Commented] (HADOOP-9322) LdapGroupsMapping doesn't seem to
 set a timeout for its directory search
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645140#comment-13645140 ] 

Aaron T. Myers commented on HADOOP-9322:
----------------------------------------

+1, the patch looks good to me.
                
> LdapGroupsMapping doesn't seem to set a timeout for its directory search
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-9322
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9322
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 2.0.3-alpha
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Minor
>              Labels: performance
>         Attachments: HADOOP-9322.patch
>
>
> We don't appear to be setting a timeout via http://docs.oracle.com/javase/6/docs/api/javax/naming/directory/SearchControls.html#setTimeLimit(int) before we search with http://docs.oracle.com/javase/6/docs/api/javax/naming/directory/DirContext.html#search(javax.naming.Name,%20java.lang.String,%20javax.naming.directory.SearchControls).
> This may occasionally lead to some unwanted NN pauses due to lock-holding on the operations that do group lookups. A timeout is better to define than rely on "0" (infinite wait).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira