hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9401) CodecPool: Add counters for number of (de)compressors leased out
Date Wed, 03 Apr 2013 21:13:15 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621327#comment-13621327
] 

Alejandro Abdelnur commented on HADOOP-9401:
--------------------------------------------

it looks good, one minor comment though. to avoid duplication, would you refactor the cache
creation into a private method?

{code}
private static <T> Cache<Class<T>, AtomicInteger> createCache(Class<T>
klass) {
  ...
}
{code}
                
> CodecPool: Add counters for number of (de)compressors leased out
> ----------------------------------------------------------------
>
>                 Key: HADOOP-9401
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9401
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.3-alpha
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: hadoop-9401.patch, hadoop-9401.patch, hadoop-9401.patch, hadoop-9401.patch
>
>
> CodecPool enables reusing compressors/decompressors created. However, the onus is on
the user to return the compressors/decompressors to the pool, and can be easily missed.
> It would be quite handy to keep track of the total number of compressors/decompressors
created and helper methods to check outstanding (not returned) compressors/decompressors.
It immediately allows Hadoop and downstream projects to write unit tests for the same.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message