hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8602) Passive mode support for FTPFileSystem
Date Wed, 24 Apr 2013 09:21:16 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640272#comment-13640272
] 

Hadoop QA commented on HADOOP-8602:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12580259/HADOOP-8602.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2470//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2470//console

This message is automatically generated.
                
> Passive mode support for FTPFileSystem
> --------------------------------------
>
>                 Key: HADOOP-8602
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8602
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: nemon lou
>            Priority: Minor
>         Attachments: HADOOP-8602.patch, HADOOP-8602.patch
>
>
>  FTPFileSystem uses active mode for default data connection mode.We shall be able to
choose passive mode when active mode doesn't work (firewall for example).
>  My thoughts is to add an option "fs.ftp.data.connection.mode" in core-site.xml.Since
FTPClient(in org.apache.commons.net.ftp package) already supports passive mode, we just need
to add a few code in FTPFileSystem .connect() method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message