Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Fri, 8 Mar 2013 14:42:14 +0000 (UTC)
From: "Steve Loughran (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12635325.1362484046329.408372.1362753734624@arcas>
In-Reply-To: <JIRA.12635325.1362484046329@arcas>
References: <JIRA.12635325.1362484046329@arcas>
Subject: [jira] [Commented] (HADOOP-9361) Write a set of tests to more
 strictly define the expected behavior of filesystems
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-9361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597174#comment-13597174 ] 

Steve Loughran commented on HADOOP-9361:
----------------------------------------

These tests must all be enabled/disabled dynamically by the FS specific subclasses, so that tests that can run against a filesystem for any reason (e.g. no S3 credentials) can be downgraded to a skip -which then appears in the test reports. This will make clear that tests were not run, whereas today the JUnit3-derived tests are named to not match the *Test pattern, and must be explicitly run by hand.
                
> Write a set of tests to more strictly define the expected behavior of filesystems
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-9361
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9361
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs, test
>    Affects Versions: 3.0.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>
> {{FileSystem}} and {{FileContract}} aren't tested rigorously enough -while HDFS gets tested downstream, other filesystems, such as blobstore bindings, don't.
> The only tests that are common are those of {{FileSystemContractTestBase}}, which HADOOP-9258 shows is incomplete.
> I propose 
> # writing more tests which clarify expected behavior
> # testing operations in the interface being in their own JUnit4 test classes, instead of one big test suite. 
> # Having each FS declare via a properties file what behaviors they offer, such as atomic-rename, atomic-delete, umask, immediate-consistency -test methods can downgrade to skipped test cases if a feature is missing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira