Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Fri, 1 Mar 2013 23:47:12 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12634918.1362176110213.368212.1362181632954@arcas>
In-Reply-To: <JIRA.12634918.1362176110213@arcas>
References: <JIRA.12634918.1362176110213@arcas>
Subject: [jira] [Commented] (HADOOP-9352) Expose UGI.setLoginUser for tests
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591105#comment-13591105 ] 

Hadoop QA commented on HADOOP-9352:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12571668/HADOOP-9352.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 tests included appear to have a timeout.{color}

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2253//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2253//console

This message is automatically generated.
                
> Expose UGI.setLoginUser for tests
> ---------------------------------
>
>                 Key: HADOOP-9352
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9352
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-9352.branch-23.patch, HADOOP-9352.patch
>
>
> The {{UGI.setLoginUser}} method is not publicly exposed, which makes it impossible to correctly test code executed outside of an explicit {{doAs}}.  {{getCurrentUser}}/{{getLoginUser}} will always vivify the login user from the user running the test, and not an arbitrary user to be determined by the test.  The method is documented with why it's not ready for prime-time, but it's good enough for tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira