hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9330) Add custom JUnit4 test runner with configurable timeout
Date Mon, 25 Mar 2013 18:47:15 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13612971#comment-13612971
] 

Steve Loughran commented on HADOOP-9330:
----------------------------------------

I'm happy with having a very long default timeout -as it's purpose is to stop Jenkins hanging.

I personally think having any timeouts in individual tests is incredibly brittle for testing
on different machines, so people should not be explicitly setting timeouts in tests except
in specific cases, where somehow they can't just set the test runner properties to change
the global default.

# What default do you think the base class should have? 100s is <2 minutes, which should
be enough for most tests -are there any which regularly come close to that time on anyone's
system? (that's excluding minicluster setup/teardown)/
# What documentation are you thinking of? Is there something on writing and running tests?
If not, it may be time.
                
> Add custom JUnit4 test runner with configurable timeout
> -------------------------------------------------------
>
>                 Key: HADOOP-9330
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9330
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Steve Loughran
>         Attachments: HADOOP-9330-timeouts-1.patch
>
>
> HADOOP-9112 has added a requirement for all new test methods to declare a timeout, so
that jenkins/maven builds will have better information on a timeout.
> Hard coding timeouts into tests is dangerous as it will generate spurious failures on
slower machines/networks and when debugging a test.
> I propose providing a custom JUnit4 test runner that test cases can declare as their
test runner; this can provide timeouts specified at run-time, rather than in-source.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message