hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9259) FileSystemContractBaseTest should be less brittle in teardown
Date Tue, 26 Mar 2013 13:04:25 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613762#comment-13613762
] 

Hudson commented on HADOOP-9259:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #1356 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1356/])
    HADOOP-9258 Add stricter tests to FileSystemContractTestBase (includes fixes for production
code HADOOP-9261 & HADOOP-9265 and test enhancements HADOOP-9228, HADOOP-9227 & HADOOP-9259)
(Revision 1460646)

     Result = FAILURE
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1460646
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/s3/Jets3tFileSystemStore.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/s3/S3FileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/s3native/NativeS3FileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemContractBaseTest.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/s3/InMemoryFileSystemStore.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/s3native/NativeS3FileSystemContractBaseTest.java

                
> FileSystemContractBaseTest should be less brittle in teardown
> -------------------------------------------------------------
>
>                 Key: HADOOP-9259
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9259
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 3.0.0, 1.1.2
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: HDFS-4409.patch
>
>
> the teardown code in FileSystemContractBaseTest assumes that {{fs!=null}} and that it's
OK to throw an exception if the delete operation fails. Better to check the {{fs}} value and
catch and convert an exception in the {{fs.delete()}} operation to a {{LOG.error()}} instead.
> This will stop failures in teardown becoming a distraction from the root causes of the
problem (that your FileSystem is broken)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message