Return-Path: 
 <common-issues-return-43736-apmail-hadoop-common-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id C8A0DE19B
	for <apmail-hadoop-common-issues-archive@minotaur.apache.org>;
 Mon, 11 Feb 2013 22:49:13 +0000 (UTC)
Received: (qmail 6128 invoked by uid 500); 11 Feb 2013 22:49:13 -0000
Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org
Received: (qmail 5973 invoked by uid 500); 11 Feb 2013 22:49:13 -0000
Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:common-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:common-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:common-issues@hadoop.apache.org>
List-Id: <common-issues.hadoop.apache.org>
Reply-To: common-issues@hadoop.apache.org
Delivered-To: mailing list common-issues@hadoop.apache.org
Received: (qmail 5959 invoked by uid 99); 11 Feb 2013 22:49:13 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Feb 2013 22:49:13 +0000
Date: Mon, 11 Feb 2013 22:49:13 +0000 (UTC)
From: "Chris Nauroth (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12618829.1354685639896.275396.1360622953370@arcas>
In-Reply-To: <JIRA.12618829.1354685639896@arcas>
References: <JIRA.12618829.1354685639896@arcas>
Subject: [jira] [Commented] (HADOOP-9117) replace protoc ant plugin exec
 with a maven plugin
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HADOOP-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576191#comment-13576191 ] 

Chris Nauroth commented on HADOOP-9117:
---------------------------------------

Regarding the rename, this is what I end up with in my hadoop-hdfs-project/hadoop-hdfs/pom.xml after applying the patch:

{code}
      <plugin>
        <groupId>org.codehaus.mojo.jspc</groupId>
        <artifactId>jspc-maven-plugin</artifactId>
        <executions>
          <execution>
            <id>hdfs</id>
            <phase>generate-sources</phase>
            <goals>
              <goal>compile</goal>
            </goals>
            <configuration>
              <compile>false</compile>
              <workingDirectory>${project.build.directory}/generated-src/main/jsp</workingDirectory>
              <webFragmentFile>${project.build.directory}/hdfs-jsp-servlet-definitions.xml</webFragmentFile>
              <packageName>org.apache.hadoop.hdfs.server.namenode</packageName>
              <sources>
                <directory>${basedir}/src/main/webapps/hdfs</directory>
                <includes>
                  <include>*.jsp</include>
                </includes>
              </sources>
            </configuration>
          </execution>
...
          <execution>
            <id>create-jsp-generated-sources-directory</id>
            <phase>initialize</phase>
            <goals>
              <goal>run</goal>
            </goals>
            <configuration>
              <target>
                <mkdir dir="target/generated-sources/java" />
              </target>
            </configuration>
          </execution>
...
{code}

JSP compilation goes to target/generated-src/main/jsp, but create-jsp-generated-sources-directory does mkdir target/generated-sources/java.

Maybe we don't need an explicit mkdir for jspc either, and this whole antrun execution can go away?

                
> replace protoc ant plugin exec with a maven plugin
> --------------------------------------------------
>
>                 Key: HADOOP-9117
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9117
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 2.0.2-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>         Attachments: HADOOP-9117.patch, HADOOP-9117.patch, HADOOP-9117.patch, HADOOP-9117.patch
>
>
> The protoc compiler is currently invoked using ant plugin exec. There is a bug in the ant plugin exec task which does not consume the STDOUT or STDERR appropriately making the build to stop sometimes (you need to press enter to continue).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira