hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9330) Add custom JUnit4 test runner with configurable timeout
Date Sun, 24 Feb 2013 22:08:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585508#comment-13585508
] 

Alejandro Abdelnur commented on HADOOP-9330:
--------------------------------------------

If using a @Rule/MethodRule Timeout I'd suggest 2 additional things:

* Have a @TestTimeout annotation as well to be able to set a timeout other than the default
for particular test method.
* Instead having a system property set the default timeout, lets specify a timeout.ratio,
with default 1, by doing this the ratio can be also applied to tests that have a custom timeout
                
> Add custom JUnit4 test runner with configurable timeout
> -------------------------------------------------------
>
>                 Key: HADOOP-9330
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9330
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Steve Loughran
>
> HADOOP-9112 has added a requirement for all new test methods to declare a timeout, so
that jenkins/maven builds will have better information on a timeout.
> Hard coding timeouts into tests is dangerous as it will generate spurious failures on
slower machines/networks and when debugging a test.
> I propose providing a custom JUnit4 test runner that test cases can declare as their
test runner; this can provide timeouts specified at run-time, rather than in-source.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message