hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9309) test failures on Windows due to UnsatisfiedLinkError in NativeCodeLoader#buildSupportsSnappy
Date Tue, 19 Feb 2013 22:35:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13581696#comment-13581696
] 

Chris Nauroth commented on HADOOP-9309:
---------------------------------------

Thanks, Arpit.  I tested this on Windows and Ubuntu with native build, and it worked great.
 Here are a couple of comments.  I am +1 for the patch after removal of some unneeded #includes
unless those #includes are there for some reason that I missed.  (See below for details.)

{code}
+      <DisableSpecificWarnings>4244</DisableSpecificWarnings>
{code}

I believe this setting would disable the warning across the whole project, right?  Another
option could be to upgrade our lz4.c.  It looks like there have been some recent changes to
address warnings seen when compiling on Windows:

http://code.google.com/p/lz4/source/detail?r=75&path=/trunk/lz4.c

I'm sure that would be a much larger scope though, so it's probably best to treat it as a
separate jira.

{code}
+#include "org_apache_hadoop.h"
+#include "org_apache_hadoop_io_nativeio_NativeIO.h"
{code}

Is it necessary to add these #includes to NativeCodeLoader.c?  I tried removing them, and
I was still able to compile.

                
> test failures on Windows due to UnsatisfiedLinkError in NativeCodeLoader#buildSupportsSnappy
> --------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9309
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9309
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native, util
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Arpit Agarwal
>         Attachments: HADOOP-9309.patch
>
>
> Checking for Snappy support calls native method {{NativeCodeLoader#buildSupportsSnappy}}.
 This method has not been implemented for Windows in hadoop.dll, so it throws {{UnsatisfiedLinkError}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message