hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9117) replace protoc ant plugin exec with a maven plugin
Date Mon, 11 Feb 2013 22:49:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576191#comment-13576191
] 

Chris Nauroth commented on HADOOP-9117:
---------------------------------------

Regarding the rename, this is what I end up with in my hadoop-hdfs-project/hadoop-hdfs/pom.xml
after applying the patch:

{code}
      <plugin>
        <groupId>org.codehaus.mojo.jspc</groupId>
        <artifactId>jspc-maven-plugin</artifactId>
        <executions>
          <execution>
            <id>hdfs</id>
            <phase>generate-sources</phase>
            <goals>
              <goal>compile</goal>
            </goals>
            <configuration>
              <compile>false</compile>
              <workingDirectory>${project.build.directory}/generated-src/main/jsp</workingDirectory>
              <webFragmentFile>${project.build.directory}/hdfs-jsp-servlet-definitions.xml</webFragmentFile>
              <packageName>org.apache.hadoop.hdfs.server.namenode</packageName>
              <sources>
                <directory>${basedir}/src/main/webapps/hdfs</directory>
                <includes>
                  <include>*.jsp</include>
                </includes>
              </sources>
            </configuration>
          </execution>
...
          <execution>
            <id>create-jsp-generated-sources-directory</id>
            <phase>initialize</phase>
            <goals>
              <goal>run</goal>
            </goals>
            <configuration>
              <target>
                <mkdir dir="target/generated-sources/java" />
              </target>
            </configuration>
          </execution>
...
{code}

JSP compilation goes to target/generated-src/main/jsp, but create-jsp-generated-sources-directory
does mkdir target/generated-sources/java.

Maybe we don't need an explicit mkdir for jspc either, and this whole antrun execution can
go away?

                
> replace protoc ant plugin exec with a maven plugin
> --------------------------------------------------
>
>                 Key: HADOOP-9117
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9117
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 2.0.2-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>         Attachments: HADOOP-9117.patch, HADOOP-9117.patch, HADOOP-9117.patch, HADOOP-9117.patch
>
>
> The protoc compiler is currently invoked using ant plugin exec. There is a bug in the
ant plugin exec task which does not consume the STDOUT or STDERR appropriately making the
build to stop sometimes (you need to press enter to continue).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message