hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9117) replace protoc ant plugin exec with a maven plugin
Date Mon, 11 Feb 2013 22:25:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576173#comment-13576173

Chris Nauroth commented on HADOOP-9117:

Thanks, Alejandro.  I applied this patch to my local copy of branch-trunk-win and tested on
Windows and Mac.  I also tested a full project build and building just each sub-module, just
to make sure there was nothing wrong with the relative paths specified in the pom.xml files.
 Everything worked great.

The code looks good.  Here are just a couple of minor questions:

-            <id>add-source</id>
-            <phase>generate-sources</phase>
-            <goals>
-              <goal>add-source</goal>
-            </goals>
-            <configuration>
-              <sources>
-                <source>${project.build.directory}/generated-sources/java</source>
-              </sources>
-            </configuration>
-          </execution>
-          <execution>
-            <id>add-test-source</id>
+            <id>add-recordcc-test-source</id>

I see that {{ProtocMojo}} contains a call to project.addCompileSourceRoot(output.getAbsolutePath()).
 Is that why we can remove the calls to build-helper-maven-plugin:add-source now?  Those had
been added so that developers doing a fresh import of the whole project into Eclipse would
get a correct classpath.  It wasn't a problem for Maven command line builds, only Eclipse.
 I just want to check that we haven't lost any functionality there.

-            <id>create-protobuf-generated-sources-directory</id>
+            <id>create-jsp-generated-sources-directory</id>

Is this rename correct?  It looks like the execution still creates target/generated-sources/java,
and that's still the directory where the protoc output .java files get saved.  I see jspc-maven-plugin
putting its output .java files in target/generated-src/main/jsp.

> replace protoc ant plugin exec with a maven plugin
> --------------------------------------------------
>                 Key: HADOOP-9117
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9117
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 2.0.2-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>         Attachments: HADOOP-9117.patch, HADOOP-9117.patch, HADOOP-9117.patch, HADOOP-9117.patch
> The protoc compiler is currently invoked using ant plugin exec. There is a bug in the
ant plugin exec task which does not consume the STDOUT or STDERR appropriately making the
build to stop sometimes (you need to press enter to continue).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message