hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8921) ant build.xml in branch-1 ignores -Dcompile.native
Date Mon, 11 Feb 2013 20:17:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576080#comment-13576080
] 

Arpit Agarwal commented on HADOOP-8921:
---------------------------------------

+1 for the minimal change that gets "ant compile" working on OS X. This change can be left
out.

{code:xml}
   <!-- taskcontroller targets -->
-  <target name="task-controller" depends="init">
+  <target name="task-controller" depends="init" if="compile.native" 
+      description="compile's task-controller if compile.native is set">
{code}

Also minor typo in the comment (no apostrophe).

{code:xml}
+  <target name="compile-native" description="compile's native code by setting the compile.native">
{code}


                
> ant build.xml in branch-1 ignores -Dcompile.native
> --------------------------------------------------
>
>                 Key: HADOOP-8921
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8921
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.2.0
>         Environment: Mac OS X 10.7.4
>            Reporter: Gopal V
>            Priority: Trivial
>              Labels: ant, autoconf, patch
>         Attachments: HADOOP-8921.4.patch, HADOOP-8921.5.patch, hadoop-8921.6.patch
>
>
> ant -Dcompile.native=false still runs autoconf and libtoolize
> According to ant 1.8 manual, any <target if> conditions are checked only after
the dependencies are run through. The current if condition in code fails to prevent the autoconf/libtool
components from running.
> Fixing it by moving the if condition up into the "compile-native" target and changing
it to a param substitution instead of being evaluated as a condition.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message