hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9164) Add version number and/or library file name to native library for easy tracking
Date Thu, 31 Jan 2013 21:03:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568095#comment-13568095
] 

Arpit Agarwal commented on HADOOP-9164:
---------------------------------------

Hi [~decster], thanks for the patch. It looks good overall. 

A few comments.

NativeLibraryChecker.java:
- Line 61-63: "null" as the default could be confused with printing a null object. Consider
using "Unavailable"?

SnappyCompressor.c:
- Line 121: Cast to void* is superfluous.
- Line 121-123: The clause fits on one line.

ZlibCompressor.c:
- Ditto

NativeCodeLoader.c:
- Line 42: Formatting - there should be spaces before and after the ternary operands. 
- Line 42: "null" as the default could be confused with printing a null object. Consider using
"Unavailable"?

Lz4Compressor.c:
- I did not understand the meaning of "[bundled:revision:43]".
                
> Add version number and/or library file name to native library for easy tracking
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-9164
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9164
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: native
>    Affects Versions: 2.0.2-alpha
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>            Priority: Minor
>         Attachments: HADOOP-9164.v1.patch, HADOOP-9164.v2.patch, HADOOP-9164.v3.patch,
HADOOP-9164.v4.2.patch, HADOOP-9164.v4.patch, HADOOP-9164.v4.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message