hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map
Date Sun, 06 Jan 2013 21:36:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13545500#comment-13545500
] 

Karthik Kambatla commented on HADOOP-9154:
------------------------------------------

Suren, The points make sense. It is different from other tests in the code base, but that
is no reason to not do it this way. Do you agree with my refactoring of the tests?

+1
                
> SortedMapWritable#putAll() doesn't add key/value classes to the map
> -------------------------------------------------------------------
>
>                 Key: HADOOP-9154
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9154
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 2.0.2-alpha
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: HADOOP-9124.patch, hadoop-9154-draft.patch, hadoop-9154.patch, hadoop-9154.patch
>
>
> In the following code from {{SortedMapWritable}}, #putAll() doesn't add key/value classes
to the class-id maps.
> {code}
>   @Override
>   public Writable put(WritableComparable key, Writable value) {
>     addToMap(key.getClass());
>     addToMap(value.getClass());
>     return instance.put(key, value);
>   }
>   @Override
>   public void putAll(Map<? extends WritableComparable, ? extends Writable> t){
>     for (Map.Entry<? extends WritableComparable, ? extends Writable> e:
>       t.entrySet()) {
>       
>       instance.put(e.getKey(), e.getValue());
>     }
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message