hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9154) SortedMapWritable#putAll() doesn't add key/value classes to the map
Date Sun, 06 Jan 2013 08:34:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13545348#comment-13545348
] 

Karthik Kambatla commented on HADOOP-9154:
------------------------------------------

Hi Suren,

Sorry I couldn't work on this. I ll try to take a look sometime this week.

Regarding matching classes, this method is to be called on MapWritable and SortedMapWritable
objects and hence couldn't use instanceof. The other option is to implement this method separately
in those classes. In this case, I thought this should be okay.
                
> SortedMapWritable#putAll() doesn't add key/value classes to the map
> -------------------------------------------------------------------
>
>                 Key: HADOOP-9154
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9154
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 2.0.2-alpha
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: HADOOP-9124.patch, hadoop-9154-draft.patch
>
>
> In the following code from {{SortedMapWritable}}, #putAll() doesn't add key/value classes
to the class-id maps.
> {code}
>   @Override
>   public Writable put(WritableComparable key, Writable value) {
>     addToMap(key.getClass());
>     addToMap(value.getClass());
>     return instance.put(key, value);
>   }
>   @Override
>   public void putAll(Map<? extends WritableComparable, ? extends Writable> t){
>     for (Map.Entry<? extends WritableComparable, ? extends Writable> e:
>       t.entrySet()) {
>       
>       instance.put(e.getKey(), e.getValue());
>     }
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message