hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Parker (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9106) Allow configuration of IPC connect timeout
Date Tue, 08 Jan 2013 18:54:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547113#comment-13547113

Robert Parker commented on HADOOP-9106:

Suresh, using a class member variable would require it to be set only once in the constructor
unless we make the setter function non-static. The passing of the conf in the setter makes
the use of static desirable but the setting of a member variable makes it undesirable, I chose
the static option since the connections are cached and so there is not a lot of time spent
trying to establish the connection.  We could set the member variable in the constructor but
that dilutes the meaning of setTimeoutConnection (even if it may not actual use case to set
it more than once). Bottom line I thought this way was the cleanest implementation.
If you still think the member variable is required please let me know if you want to set it
once in the constructor or remove the static qualifier from the function.
Thanks for reviewing the patch,
> Allow configuration of IPC connect timeout
> ------------------------------------------
>                 Key: HADOOP-9106
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9106
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 3.0.0
>            Reporter: Todd Lipcon
>            Assignee: Robert Parker
>         Attachments: HADOOP-9106v1.patch, HADOOP-9106v2.patch, HADOOP-9106v3.patch
> Currently the connection timeout in Client.setupConnection() is hard coded to 20seconds.
This is unreasonable in some scenarios, such as HA failover, if we want a faster failover
time. We should allow this to be configured per-client.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message