hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9106) Allow configuration of IPC connect timeout
Date Tue, 15 Jan 2013 22:12:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554436#comment-13554436
] 

Suresh Srinivas commented on HADOOP-9106:
-----------------------------------------

bq. I would like to leave "final public static" for consistency and file a separate ticket
to change all the uses of "final public static" to "public static final".
The code has mix of both public static final and other non standard variants. So the new code
could just use the right convention. But I will leave it up to you. +1 for making the code
consistent in a separate jira.

bq. We could set the member variable in the constructor but that dilutes the meaning of setTimeoutConnection
(even if it may not actual use case to set it more than once).
The setConnectionTimeout() is setting a parameter in Configuration object and has nothing
to with {{Client}} class, right? So, I fail to understand the above point.

The way I see it, {{Client}} gets {{Configuration}} in the constructor. That is the only point
in time, the connection timeout for a client is decided. This is formalized also with member
variable {{conf}} declared as final. Given that I do not understand why the timeout cannot
be set in a final member variable of Client, to clearly show that it is only set once during
creation/construction time.
                
> Allow configuration of IPC connect timeout
> ------------------------------------------
>
>                 Key: HADOOP-9106
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9106
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 3.0.0
>            Reporter: Todd Lipcon
>            Assignee: Robert Parker
>         Attachments: HADOOP-9106v1.patch, HADOOP-9106v2.patch, HADOOP-9106v3.patch
>
>
> Currently the connection timeout in Client.setupConnection() is hard coded to 20seconds.
This is unreasonable in some scenarios, such as HA failover, if we want a faster failover
time. We should allow this to be configured per-client.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message