hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-8924) Hadoop Common creating package-info.java must not depend on sh, at least for Windows
Date Sat, 12 Jan 2013 16:42:12 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-8924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Chris Nauroth updated HADOOP-8924:

    Attachment: HADOOP-8924.4.patch

I'm attaching version 4 of the patch.  Jenkins reported new javadoc warnings.  This was caused
by the non-standard doclet tags like @goal used by Maven.  To resolve this, I've switched
the code to use Maven's plugin annotations instead of doclet tags.

Additionally, Jenkins reported a failure for this patch during mvn eclipse:eclipse.  This
is actually a bug in test-patch.sh.  I've submitted a separate patch to address that in HADOOP-9202.
 The HADOOP-9202 patch must be committed first before we can commit HADOOP-8924, so I would
appreciate a code review on that one too.  It's a small diff that just reorders some of the
build steps.

Jenkins also gave -1 for no new tests.  I think this is acceptable for a piece of build scripting,
but if you disagree, let me know, and I can work on some tests.

> Hadoop Common creating package-info.java must not depend on sh, at least for Windows
> ------------------------------------------------------------------------------------
>                 Key: HADOOP-8924
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8924
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Alejandro Abdelnur
>             Fix For: trunk-win
>         Attachments: HADOOP-8924.2.patch, HADOOP-8924.3.patch, HADOOP-8924.3.patch, HADOOP-8924.4.patch,
HADOOP-8924-branch-trunk-win.2.patch, HADOOP-8924-branch-trunk-win.3.patch, HADOOP-8924-branch-trunk-win.4.patch,
HADOOP-8924-branch-trunk-win.patch, HADOOP-8924.patch
> Currently, the build process relies on saveVersion.sh to generate package-info.java with
a version annotation.  The sh binary may not be available on all developers' machines (e.g.
Windows without Cygwin). This issue tracks removal of that dependency in Hadoop Common.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message