Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 285EEDE8E for ; Thu, 27 Dec 2012 08:32:15 +0000 (UTC) Received: (qmail 4515 invoked by uid 500); 27 Dec 2012 08:32:14 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 4189 invoked by uid 500); 27 Dec 2012 08:32:14 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 4131 invoked by uid 99); 27 Dec 2012 08:32:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Dec 2012 08:32:12 +0000 Date: Thu, 27 Dec 2012 08:32:12 +0000 (UTC) From: "Arun A K (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-9168) The Naming and Inheritance for RecordReader, LineRecordReader, LineReader MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun A K updated HADOOP-9168: ----------------------------- Labels: Hadoop InputFormat (was: ) > The Naming and Inheritance for RecordReader, LineRecordReader, LineReader > -------------------------------------------------------------------------- > > Key: HADOOP-9168 > URL: https://issues.apache.org/jira/browse/HADOOP-9168 > Project: Hadoop Common > Issue Type: Improvement > Components: util > Affects Versions: 0.21.0, 2.0.2-alpha, 0.23.5 > Reporter: Gelesh > Priority: Minor > Labels: Hadoop, InputFormat > Fix For: site, hudson, 1.2.0, 0.23.2 > > Original Estimate: 96h > Remaining Estimate: 96h > > I feel LineReader is not the correct name, since it reads up to a given delimiter. > How about Text Record Reader ? > Sounds correct but LineReader is not a RecordReader by inheritance, > but by functionality , yes it is the Record reader. > Now if we look at it with a different angle, > In General, > InputFormat would mostly has two responsibilities > 1)To Read A split > 2)Generate Key & Value pairs based upon the Reading done over Split. > Now in TextInputFormat, > Has a RecordReader, Which is inherited by LineRecordReader, > which uses another class LineReader. > But We Have > LineReader, which does the reading of the file. > LineRecordReader generates key & Value. > I would suggest, > RecordReader to be renamed as KeyValueGenerator, > LineRecordReader to be renamed as TextInputKeyValueGenerator, > LineReader to be renamed as delimitedTextReader, > Generic attributes of LineReader (such as start, pos, end, buffer, bufferBytes .. etc ) to be abstracted to a class called RecordReader, > Since its all specific to reading of the given input. > delimitedTextReader class could extend RecordReader. > Now the names could make better scene. We must also look into computability as well. It might be un fit to deploy unless a new API is introduced. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira