Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7F90ED1F3 for ; Mon, 24 Dec 2012 17:50:13 +0000 (UTC) Received: (qmail 73607 invoked by uid 500); 24 Dec 2012 17:50:13 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 73498 invoked by uid 500); 24 Dec 2012 17:50:12 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 73480 invoked by uid 99); 24 Dec 2012 17:50:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Dec 2012 17:50:12 +0000 Date: Mon, 24 Dec 2012 17:50:12 +0000 (UTC) From: "Karthik Kambatla (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-9154) SortedMap#putAll() doesn't add key/value classes to the map MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539297#comment-13539297 ] Karthik Kambatla commented on HADOOP-9154: ------------------------------------------ Yes, that should suffice. > SortedMap#putAll() doesn't add key/value classes to the map > ----------------------------------------------------------- > > Key: HADOOP-9154 > URL: https://issues.apache.org/jira/browse/HADOOP-9154 > Project: Hadoop Common > Issue Type: Bug > Components: io > Affects Versions: 2.0.2-alpha > Reporter: Karthik Kambatla > Assignee: Karthik Kambatla > > In the following code from {{SortedMapWritable}}, #putAll() doesn't add key/value classes to the class-id maps. > {code} > @Override > public Writable put(WritableComparable key, Writable value) { > addToMap(key.getClass()); > addToMap(value.getClass()); > return instance.put(key, value); > } > @Override > public void putAll(Map t){ > for (Map.Entry e: > t.entrySet()) { > > instance.put(e.getKey(), e.getValue()); > } > } > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira