hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9151) Include RPC error info in RpcResponseHeader instead of sending it separately
Date Fri, 21 Dec 2012 02:13:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537620#comment-13537620
] 

Todd Lipcon commented on HADOOP-9151:
-------------------------------------

bq. getting rid of writable in serialized rpc request and response is equally important

It's not a custom writable. It's a 4-byte length-prefixed string (which happens to be implemented
by a class called WritableUtils). This is super easy to serialize in any language. In fact,
anyone implementing RPC already needs to implement length-prefixed strings in order to send
the protos themselves.

I won't debate it's a wart. It's just not worth the pain to fix it in branch-2 when it doesn't
buy us any real advantages.

bq. I and Sanjay have spent quite a lot of time on this

It's a 5kb patch...?
                
> Include RPC error info in RpcResponseHeader instead of sending it separately
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-9151
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9151
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: HADOOP-9151.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message