hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9147) Add missing fields to FIleStatus.toString
Date Sun, 16 Dec 2012 22:40:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533543#comment-13533543
] 

Suresh Srinivas commented on HADOOP-9147:
-----------------------------------------

Thanks for the patch.

Comments:
# The toString tests should reuse code. You could have a method validateToString(FileStatus
status) that could be used by all the variants of the methods that are testing toString()
# Similarly you can have a method for validateAccessors(FileStatus status, len, isDir, replication...)
etc.
# Please keep your code consistent. If have a blank line before a method, do the same for
other methods.
# Please add javadoc to every method with a brief description of what the test does.

                
> Add missing fields to FIleStatus.toString
> -----------------------------------------
>
>                 Key: HADOOP-9147
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9147
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Jonathan Allen
>            Assignee: Jonathan Allen
>            Priority: Trivial
>         Attachments: HADOOP-9147.patch, HADOOP-9147.patch
>
>
> The FileStatus.toString method is missing the following fields:
> - modification_time
> - access_time
> - symlink
> These should be added in to aid debugging.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message